Implementation and Design Smell Fixes #963
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of code done to address some design smells and implementation smells.
Implementation smells fixed:
Complex Conditional: getBoolean method in JSONArray.
Techniques: Extract Method, Decompose Conditional, Introduce Explaining Variable
• Extract Method - Created isFalse() and isTrue() methods to handle the complex conditionals
• Decompose Conditional - Broke down the complex if-conditions into simpler methods
• Introduce Explaining Variable - Used isBooleanString to clarify the string check logic
Complex Conditional: nextTo method in JSONTokener
Techniques: Extract Method, Decompose Conditional, Introduce Explaining Variable
• Extract Method - Created isDelimiter() helper methods to encapsulate delimiter checks
• Decompose Conditional - Broke down complex OR conditions into simpler checks
• Introduce Explaining Variable - Used isEndOfInput to clarify the zero-character check
Magic Number: toString method in JSONArray
Techniques: Introduce explaining variable
• Introduce explaining variable (for magic number 2) - Explain the multiplier purpose
• Introduce explaining variable (for magic number 16) - Explain minimum buffer size
Design smells fixed:
Technique: Move Field/Method
Technique: Extract Class
Technique: Replace conditional with Polymorphism